Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make outline's opacity independent on window's opacity #225

Merged
merged 1 commit into from
May 17, 2024

Conversation

matinlotfali
Copy link
Owner

This is to fix #221

@matinlotfali matinlotfali merged commit 74a583b into master May 17, 2024
9 checks passed
@matinlotfali matinlotfali deleted the 221-force-outline-opacity-to-100 branch May 17, 2024 23:54
@scgm0
Copy link

scgm0 commented May 20, 2024

There are some side effects....
图片

@matinlotfali
Copy link
Owner Author

@scgm0 can you test #229 and see if it fixes it?

@scgm0
Copy link

scgm0 commented May 21, 2024

@scgm0 can you test #229 and see if it fixes it?

Didn't solve the problem, I tried using vec4 outlineOverlay = vec4(mix(tex.rgb, outlineColor.rgb, outlineColor.a), tex.a); and found that there is still a very shallow outline, maybe there is something else affecting tex.a?
图片

@matinlotfali
Copy link
Owner Author

Instead of tex.a > 0.0 in the if condition, can you try tex.a > 0.1?

@scgm0
Copy link

scgm0 commented May 21, 2024

Instead of tex.a > 0.0 in the if condition, can you try tex.a > 0.1?

It played a role!

@matinlotfali
Copy link
Owner Author

Fantastic. I will merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to force outline opacity to 100% regardless of the window opacity
2 participants