Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw my own shadows all over with proper active & inactive configuration #82

Merged
merged 2 commits into from
Jun 18, 2023

Conversation

matinlotfali
Copy link
Owner

In this pull request, I am removing the native shadows and I am drawing my own shadows instead to fix issue #59

@matinlotfali matinlotfali linked an issue Jun 18, 2023 that may be closed by this pull request
@matinlotfali matinlotfali merged commit 923f705 into master Jun 18, 2023
@matinlotfali matinlotfali deleted the draw-shadows branch June 18, 2023 04:57
@developer91234
Copy link

So does that mean it's possible to force shadows on CSD windows? (Obviously one can force them on KDE by forcing server decoration, then adding an exclusion to remove the titlebar. However this process is labor intensive and depends on the decoration having that toggle)

@developer91234
Copy link

Ask because there are no shadows for VSCode when run with CSD, just an outline.
But the effect does force its own system-wide shadows on GTK4 CSD apps.

@matinlotfali
Copy link
Owner Author

@developer91234 No I am injecting my own shader into the window. If the window doesn't already have a shadow, I can't draw my own version.

In KWin terms, if expandedGeometry is bigger than frameGeometry, I can draw my shadow. But if they are equal, I can't.

@developer91234
Copy link

oh I see.

@developer91234
Copy link

Maybe there's some way to force SSD from within the effect, then modify it so that it strips out the titlebar and frame?

@matinlotfali
Copy link
Owner Author

@developer91234 that would become part of the KDecoration domain and not the KWinEffects.

@developer91234
Copy link

@matinlotfali I guess one way to do it would be to force server decorations on an app, then use the effect to cut out the titlebar area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

corner is not fully transparent
2 participants