Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: android 14 permission support #60

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Conversation

matinzd
Copy link
Owner

@matinzd matinzd commented Jan 20, 2024

BREAKING CHANGE: You will need to make some changes to your MainActivity.kt file

Blocked by: facebook/react-native#42403

BREAKING CHANGE: You will need to make some changes to your `MainActivity.kt` file
@matinzd matinzd linked an issue Jan 20, 2024 that may be closed by this pull request
Copy link
Collaborator

@TheRogue76 TheRogue76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. This is why my side projects never have Android. If the API is gonna be shitty, make it non-depracatable like web, and if it is depracatable make it not shitty like iOS. Android does neither

@matinzd
Copy link
Owner Author

matinzd commented Jan 22, 2024

Waiting for facebook/react-native#42478 to be merged.

@TheRogue76
Copy link
Collaborator

Unblocked. Go for it

TheRogue76
TheRogue76 previously approved these changes Jan 22, 2024
@matinzd
Copy link
Owner Author

matinzd commented Jan 22, 2024

We need to wait for the release crew to start back-porting this fix to older versions of RN:

RN 73: reactwg/react-native-releases#98 (comment)
RN 71 reactwg/react-native-releases#99 (comment)
RN 72: reactwg/react-native-releases#100 (comment)

@mgarcialeniolabs
Copy link

Any updates on this? Can see that on RN the changes has been merged.

@matinzd
Copy link
Owner Author

matinzd commented Feb 5, 2024

Any updates on this? Can see that on RN the changes has been merged.

I am still waiting for the backport fix for 72.

@icernigoj
Copy link

Hey there

I'm really looking forward to this update. Is there any way I can help move things along?

@KesoGizmoYoshi
Copy link

Hey there

I'm really looking forward to this update. Is there any way I can help move things along?

I think you just have to wait for React Native 0.72.11 to be released.

@abdullatifHH
Copy link

+1
@matinzd is there any update on this.

@matinzd
Copy link
Owner Author

matinzd commented Feb 22, 2024

Waiting for RN 72 patch. Until then, no updates.

@matinzd matinzd merged commit 1dbe8f3 into main Feb 22, 2024
3 checks passed
@matinzd matinzd deleted the breaking_change_android_14 branch February 22, 2024 17:51
@mmeinzer
Copy link

@matinzd We upgraded to the latest version of RN 73 and this package with the Android 14 fix but get the error that seems related to the update mentioned in the Readme to MainActivity.kt. We don't currently maintain any custom native code in our project (we use Expo) - is that something we will need to do in order to get v2 of react-native-health-connect working?

@matinzd
Copy link
Owner Author

matinzd commented Feb 29, 2024

@matinzd We upgraded to the latest version of RN 73 and this package with the Android 14 fix but get the error that seems related to the update mentioned in the Readme to MainActivity.kt. We don't currently maintain any custom native code in our project (we use Expo) - is that something we will need to do in order to get v2 of react-native-health-connect working?

I need to publish a version that uses expo modules api 😅 or you can use expo dev client and eject your android folder.

@topherauyeung
Copy link

@matinzd any chance you've got updates here on a version that uses the Expo Modules API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requestPermission on Android 14
8 participants