-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: android 14 permission support #60
Conversation
BREAKING CHANGE: You will need to make some changes to your `MainActivity.kt` file
example/android/app/src/main/java/com/healthconnectexample/PermissionRationaleActivity.kt
Show resolved
Hide resolved
example/android/app/src/main/java/com/healthconnectexample/MainActivity.kt
Show resolved
Hide resolved
android/src/main/java/dev/matinzd/healthconnect/permissions/HealthConnectPermissionDelegate.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. This is why my side projects never have Android. If the API is gonna be shitty, make it non-depracatable like web, and if it is depracatable make it not shitty like iOS. Android does neither
Waiting for facebook/react-native#42478 to be merged. |
Unblocked. Go for it |
We need to wait for the release crew to start back-porting this fix to older versions of RN: RN 73: reactwg/react-native-releases#98 (comment) |
Any updates on this? Can see that on RN the changes has been merged. |
I am still waiting for the backport fix for 72. |
Hey there I'm really looking forward to this update. Is there any way I can help move things along? |
I think you just have to wait for React Native 0.72.11 to be released. |
+1 |
Waiting for RN 72 patch. Until then, no updates. |
@matinzd We upgraded to the latest version of RN 73 and this package with the Android 14 fix but get the error that seems related to the update mentioned in the |
I need to publish a version that uses expo modules api 😅 or you can use expo dev client and eject your android folder. |
@matinzd any chance you've got updates here on a version that uses the Expo Modules API? |
BREAKING CHANGE: You will need to make some changes to your
MainActivity.kt
fileBlocked by: facebook/react-native#42403