Add PartialEq, From<T> derives + Fix rustc 1.24.1 builds #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, I think we defenetely can’t implement Hash: otherwise, you can store an empty cell in a hash map, then fill it, and get a hash map in an inconsistent state. It can be said that Eq and Ord could screw data structures in a similar way, but I think I’d be fine with those. Cc |
|
I've removed the Hash derives. |
matklad
reviewed
Jan 11, 2019
| self.get() == other.get() | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This probably needs to be duplicated in impl_std?
And perhaps it makes sense to add a trivial test for this API as well, exactly to test that both impls in fact have the same api?
mmstick
force-pushed
the
extra-derives
branch
from
843c2b9 to
492dcbf
Compare
mmstick
force-pushed
the
extra-derives
branch
from
492dcbf to
4044453
Compare
mmstick
changed the title
|
Awesome, thanks! |
|
released as 0.1.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to use this within System76 / Pop!_OS projects, but that requires an extra derive (PartialEq), and using
useimport syntax that's compatible with rustc 1.24.1. While I was there, added some additional missing derives (Hash, From).