Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using non-existant cfg to not trigger lint #97

Merged
merged 3 commits into from
Nov 16, 2024

Conversation

Urgau
Copy link
Contributor

@Urgau Urgau commented Nov 10, 2024

This PR replace the non-existant trick_rust_analyzer_into_highlighting_interpolated_bits cfg in the cmd! macro with an always false cfg expression, as to not trigger the upcoming unexpected_cfgs lint report in macro.

cc rust-lang/rust#132577
cc @matklad

Copy link
Collaborator

@lnicola lnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Can you bump the version number too?

@lnicola lnicola merged commit 9a40594 into matklad:master Nov 16, 2024
4 checks passed
CosterM added a commit to CosterM/leafwing_abilities that referenced this pull request Dec 3, 2024
Older xshell does not play nicely with current nightly rust, and possibly upcoming rust 1.84.0 See matklad/xshell#97
CosterM added a commit to CosterM/leafwing_abilities that referenced this pull request Dec 3, 2024
Xshell 1.0 is not compatible with nightly rust, and may not be comatible with upcoming stable rust versions. See matklad/xshell#97
CosterM added a commit to CosterM/leafwing_abilities that referenced this pull request Dec 3, 2024
Xshell 1.0 is not compatible with nightly rust, and may not be comatible with upcoming stable rust versions. See matklad/xshell#97
CosterM added a commit to CosterM/leafwing_abilities that referenced this pull request Dec 3, 2024
Xshell 1.0 is not compatible with nightly rust, and may not be comatible with upcoming stable rust versions. See matklad/xshell#97
alice-i-cecile pushed a commit to Leafwing-Studios/leafwing_abilities that referenced this pull request Dec 3, 2024
Xshell 1.0 is not compatible with nightly rust, and may not be comatible with upcoming stable rust versions. See matklad/xshell#97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants