gpt-4o-mini does handle images #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Permit sending images to gpt-4o-mini. Also, change `DescribeImagesUsingChatGPT` example to use the default model (now gpt-4o-mini), and while we are editing it anyway, remove the `addpath` and `loadenv` lines and use the newer `wrapText` utility function.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=======================================
Coverage 97.12% 97.12%
=======================================
Files 39 39
Lines 1287 1287
=======================================
Hits 1250 1250
Misses 37 37 ☔ View full report in Codecov by Sentry. |
vpapanasta
reviewed
Jul 22, 2024
vpapanasta
reviewed
Jul 22, 2024
tests/topenAIChat.m
Outdated
| @@ -190,7 +190,7 @@ function assignValueToProperty(property, value) | |||
| end | |||
|
|
|||
| function invalidGenerateInputforModel(testCase) | |||
There was a problem hiding this comment.
It would be great to add an equivalent positive test for the default gpt-4o-mini model.
vpapanasta
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permit sending images to gpt-4o-mini.
Also, change
DescribeImagesUsingChatGPTexample to use the default model (now gpt-4o-mini), and while we are editing it anyway, remove theaddpathandloadenvlines and use the newerwrapTextutility function.Fixes #51