Add Gandi VirtualHost log format #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
requested changes
Jun 24, 2021
There was a problem hiding this comment.
Hi @tups
Thanks for the contribution. The current implementation seems not to work due to a typo in the format name.
Also it would be awesome if you could add a test for the new format with a small example log. See other tests in https://github.com/matomo-org/matomo-log-analytics/blob/4.x-dev/tests/test_main.py
added 2 commits
June 25, 2021 07:25
…t API. The response was detected in byte. Adding a decoder depending on the response.
sgiehl
reviewed
Jun 25, 2021
diosmosis
reviewed
Jun 27, 2021
diosmosis
reviewed
Jun 28, 2021
|
Thanks for the PR @tups and thanks for applying all the requested review feedback! |
metalocator
reviewed
Sep 15, 2021
| @@ -1527,9 +1538,10 @@ def _call(self, path, args, headers=None, url=None, data=None): | |||
| self.RedirectHandlerWithLogging(), | |||
| urllib.request.HTTPSHandler(**https_handler_args)) | |||
| response = opener.open(request, timeout = timeout) | |||
| encoding = response.info().get_content_charset('utf-8') | |||
There was a problem hiding this comment.
This line and the result.decode below caused the issue described here:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I suggest adding the regex for Gandi's virtualhost servers, because the log format is different.
Thank you anyway for your work
Review