Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests and simplify #332

Merged
merged 2 commits into from
Jul 10, 2022
Merged

Fix tests and simplify #332

merged 2 commits into from
Jul 10, 2022

Conversation

hannesa2
Copy link
Collaborator

close #330

Now ./gradlew test works locally
image

hannesa2
hannesa2 commented Jul 10, 2022
View reviewed changes
tracker/src/test/java/org/matomo/sdk/extra/CustomVariablesTest.java
@@ -1,6 +1,5 @@
package org.matomo.sdk.extra;

import org.apache.maven.artifact.ant.shaded.StringUtils;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to remove this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me2, weird to have that 😁

@codecov-commenter
Copy link

Codecov Report

Merging #332 (4036b8e) into master (1e62b6f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #332   +/-   ##
=========================================
  Coverage     86.24%   86.24%           
  Complexity      371      371           
=========================================
  Files            33       33           
  Lines          1425     1425           
  Branches        167      167           
=========================================
  Hits           1229     1229           
  Misses          125      125           
  Partials         71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e62b6f...4036b8e. Read the comment docs.

@hannesa2 hannesa2 added the bug label Jul 10, 2022
d4rken
d4rken approved these changes Jul 10, 2022
View reviewed changes
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

tracker/src/test/java/org/matomo/sdk/extra/CustomVariablesTest.java
@@ -1,6 +1,5 @@
package org.matomo.sdk.extra;

import org.apache.maven.artifact.ant.shaded.StringUtils;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me2, weird to have that 😁

@d4rken d4rken merged commit 7216a32 into master Jul 10, 2022
@d4rken d4rken deleted the FixTests branch July 10, 2022 10:05
@hannesa2 hannesa2 mentioned this pull request Jul 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4rken d4rken d4rken approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannesa2 @codecov-commenter @d4rken