Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On very high traffic Piwik servers, prevent integer overflow by making auto_increment fields BIGINT UNSIGNED #10548

Merged
merged 13 commits into from
Sep 26, 2016
Merged

On very high traffic Piwik servers, prevent integer overflow by making auto_increment fields BIGINT UNSIGNED #10548

merged 13 commits into from
Sep 26, 2016

Conversation

mattab
Copy link
Member

@mattab mattab commented Sep 23, 2016 •
edited
Loading

  • New system test that forces an integer overflow, initially failing as expected
  • Make all overflow-able fields BIGINT UNSIGNED in the schema
  • Add the Update script to manually modify all the fields (which aren't yet Dimension columns) from INT to BIGINT
  • Install a clean Piwik 3.0.0-b1 - manually compare the schema to an upgraded 2.16.0 -> 3.0.0-b1 and confirm the schema is same

Fixes #3288

@mattab mattab added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Sep 23, 2016
@mattab mattab added this to the 3.0.0-b1 milestone Sep 23, 2016
@mattab mattab self-assigned this Sep 23, 2016
@mattab mattab mentioned this pull request Sep 23, 2016
Closed
@mattab mattab merged commit cdc50dc into 3.x-dev Sep 26, 2016
@mattab mattab deleted the bigint branch September 26, 2016 00:04
mattab
mattab commented Sep 26, 2016
View reviewed changes
core/Db/Schema/Mysql.php
idaction_name_ref INTEGER(10) UNSIGNED NULL,
idvisit BIGINT(10) UNSIGNED NOT NULL,
idaction_url_ref BIGINT(10) UNSIGNED NULL DEFAULT 0,
idaction_name_ref BIGINT(10) UNSIGNED NULL,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: starting in Piwik 3 each pageview now has 16 bytes overhead.

@mattab mattab added c: Performance For when we could improve the performance / speed of Matomo. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. labels Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mattab mattab

Labels
c: Performance For when we could improve the performance / speed of Matomo. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Milestone
3.0.0-b1
Development

Successfully merging this pull request may close these issues.
1 participant
@mattab