Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unformatted / raw data for new All Websites dashboard #22751

Merged
merged 10 commits into from
Nov 21, 2024
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 12, 2024

Description:

This PR contains the following changes:

  • The JavaScript NumberFormatter class has been migrated to vue.js
  • The getFormattedEvolution javascript method has been migrated to the new NumberFormatter
  • The MultiSites API method have been improved/fixed to
    • Return proper metric names for previous period (e.g. previous_hits instead of previous_Actions_hits)
    • Return metrics for previous period in totals
    • Removed mock data API method
  • The new MultiSites Dashboard UI has been improved to
    • Use the normal API instead of mock
    • Request API data unformatted
    • Calculate evolutions based on current and previous data (instead of using the evolution metrics provided by API)
    • Format all numbers correctly before displaying the using the new NumberFormatter component
  • Improved / Updated / Added tests

Note: There is still a lot code, that needs some more refactoring. We should aim to do that as part of removing the old all websites dashboard.

Review

@sgiehl sgiehl added this to the 5.2.0 milestone Nov 12, 2024
@sgiehl sgiehl force-pushed the dev-18265 branch 5 times, most recently from 7f3a2d2 to 26a75aa Compare November 13, 2024 10:44
@sgiehl sgiehl requested a review from a team November 13, 2024 16:03
@sgiehl sgiehl added the Needs Review PRs that need a code review label Nov 13, 2024
@sgiehl sgiehl marked this pull request as ready for review November 13, 2024 16:03
plugins/MultiSites/API.php Outdated Show resolved Hide resolved
plugins/MultiSites/API.php Outdated Show resolved Hide resolved
plugins/MultiSites/API.php Show resolved Hide resolved
@sgiehl sgiehl merged commit fc2f209 into 5.x-dev Nov 21, 2024
26 checks passed
@sgiehl sgiehl deleted the dev-18265 branch November 21, 2024 11:06
@mneudert mneudert mentioned this pull request Nov 26, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants