Fix overlay test that fails on the first day of the month / Fix overlay

[caddoo]

Description

A particular UI test always failed on the first day of the month. Due to the large shared fixture used for UI tests, probably this bit:

matomo/tests/PHPUnit/Fixtures/UITestFixture.php

Line 278 in 468d12b

$date = Date::factory('yesterday');

Rather than modify that, I just changed the test to switch the view to 'yesterday' so the layout/values are consistent, as a bonus it also makes sure the period switcher works.

Additional

I also noticed that the sidebar didn't load on first load leading to an infinite spinner, it did work in the UI tests but not in when testing (see here for demo) so I've corrected that as well.

Testing

To test this change, I changed the date when running the UI tests using:
exec('sudo date --set="2024-11-01 12:00:00"');

Here is the change running with the date 2024-11-05 and it passing.
https://github.com/matomo-org/matomo/actions/runs/11926632491/job/33242601919#step:3:807

Here is the change running with the date 2024-11-01 and it passing.
https://github.com/matomo-org/matomo/actions/runs/11927626971/job/33243296429#step:3:805

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed