Add initiate cancel reset password step #22810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caddoo
changed the title
caddoo
commented
Dec 2, 2024
| $errorMessage = $ex->getMessage(); | ||
| } | ||
|
|
||
| $nonce = Nonce::getNonce(self::NONCE_CONFIRMCANCELRESETPASSWORD); |
There was a problem hiding this comment.
Don't really know if the nonce is necessary but it doesn't hurt
sgiehl
requested changes
Dec 2, 2024
plugins/Login/Controller.php
Outdated
Comment on lines
489
to
492
| $isNonceValid = Nonce::verifyNonce(self::NONCE_CONFIRMCANCELRESETPASSWORD, $request->getStringParameter('nonce')); | ||
| if ($isNonceValid === false) { | ||
| throw new Exception('Cannot verify request'); | ||
| } |
There was a problem hiding this comment.
You could use Nonce::checkNonce instead. That should directly throw a form validation exception if the nonce does not match and will also discard the nonce.
Also you need to do the nonce check before the actually action is performed!
There was a problem hiding this comment.
Thanks, I've fixed this.
Co-authored-by: Stefan Giehl <stefan@matomo.org>
…ore action is performed.
sgiehl
reviewed
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A problem was discovered with the cancel reset password flow where email link scanners would unintentionally cancel the reset password flow during their scan.
This adds a new screen in between that action to prevent that from happening.
Review