-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine actions into one column #177
Conversation
Could I please get a quick review @matomo-org/plugin-reviewers ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snake14 The changes looks good, but today during the demo it was raised that the header and the buttons are not aligned properly, can you please check that if we can align this quickly ?
@AltamashShaikh Are they talking about the icons not lining up with the left of the header text? Unless I'm missing something, it's aligned the same way as TagManager, AbTesting, CustomDimensions, CustomReports, FormAnalytics, Goals, Funnels, and other tables. |
@snake14 If you see, the edit icon is more on right compare to header "Action", I would suggest check with PO once, if its standard across all the pages, we can leave it as it is. |
I'm also seeing the same alignment in other tables, so I don't see that alignment needs to be addressed in this PR. We might want to look at table/column alignments as a separate piece of work though 👍 |
Description:
Combine actions into one column
Review