Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine actions into one column #177

Merged
merged 2 commits into from
May 29, 2024

Conversation

snake14
Copy link
Contributor

@snake14 snake14 commented May 27, 2024

Description:

Combine actions into one column

Review

@snake14
Copy link
Contributor Author

snake14 commented May 27, 2024

Could I please get a quick review @matomo-org/plugin-reviewers ?

@AltamashShaikh AltamashShaikh requested a review from a team May 28, 2024 04:08
Copy link
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snake14 The changes looks good, but today during the demo it was raised that the header and the buttons are not aligned properly, can you please check that if we can align this quickly ?

Screenshot from 2024-05-28 13-20-21

@snake14
Copy link
Contributor Author

snake14 commented May 28, 2024

@snake14 The changes looks good, but today during the demo it was raised that the header and the buttons are not aligned properly, can you please check that if we can align this quickly ?

Screenshot from 2024-05-28 13-20-21

@AltamashShaikh Are they talking about the icons not lining up with the left of the header text? Unless I'm missing something, it's aligned the same way as TagManager, AbTesting, CustomDimensions, CustomReports, FormAnalytics, Goals, Funnels, and other tables.

@AltamashShaikh
Copy link
Contributor

@snake14 The changes looks good, but today during the demo it was raised that the header and the buttons are not aligned properly, can you please check that if we can align this quickly ?
Screenshot from 2024-05-28 13-20-21

@AltamashShaikh Are they talking about the icons not lining up with the left of the header text? Unless I'm missing something, it's aligned the same way as TagManager, AbTesting, CustomDimensions, CustomReports, FormAnalytics, Goals, Funnels, and other tables.

@snake14 If you see, the edit icon is more on right compare to header "Action", I would suggest check with PO once, if its standard across all the pages, we can leave it as it is.

@Stan-vw
Copy link

Stan-vw commented May 29, 2024

I'm also seeing the same alignment in other tables, so I don't see that alignment needs to be addressed in this PR. We might want to look at table/column alignments as a separate piece of work though 👍

@snake14 snake14 merged commit 2470806 into 5.x-dev May 29, 2024
5 checks passed
@snake14 snake14 deleted the PG-3416-combine-actions-into-single-column branch May 29, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants