Setup embedded tracker environment correctly in queuedtracking:process #17
Conversation
…using Environment instance instead of trying to clear the container.
| @@ -37,13 +35,15 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| $systemCheck = new SystemCheck(); | |||
| $systemCheck->checkRedisIsInstalled(); | |||
|
|
|||
| Access::getInstance()->setSuperUserAccess(false); | |||
| Plugin\Manager::getInstance()->setTrackerPluginsNotToLoad(array('Provider')); | |||
| $trackerEnvironment = new Environment('tracker'); | |||
There was a problem hiding this comment.
Will this recreate the container and clear any previous created instances? Especially re the Cache? I'm not into the environment / container code so just asking :)
There was a problem hiding this comment.
it doesn't recreate the container, it creates a new one w/ the tracker environment. For now, this pushes a container instance onto a stack so StaticContainer::get() will use the top. Which I think means I missed something, there should probably be a $trackerEnvironment->destroy() call after processing is done, so control goes back to the CLI environment.
Note: This means there's a new Plugin\Manager and should be new Plugin instances stored in $trackerEnvironment. Since it's only done once here, shouldn't be an issue.
Eventually, we'll get rid of StaticContainer so everything is provided through DI, then we just use the environment directly and worry about nothing.
There was a problem hiding this comment.
Looks like this PR will fix a couple of issues.
Which I think means I missed something, there should probably be a $trackerEnvironment->destroy() call after processing is done, so control goes back to the CLI environment.
Does this mean there's more work left?
There was a problem hiding this comment.
Should be done w/ my last commit.
|
I tested the patch. It's still not working. I got the following error: |
… and fix Processor::process() call.
|
@ldidry fixed that error in my last commit. |
|
This error is fixed, indeed. But there is another problem: I got 534455 requests to process (said queuedtracking:monitor) but when I launch the process command, it says: |
Setup embedded tracker environment correctly in queuedtracking:process
|
Thx @diosmosis It looks like it works now, tested as well. Also seems to use the right environement/cache (which is important for performance etc) |
|
It worked for me. @ldidry are you still getting this error with latest version (0.1.7)? Can you maybe update to Piwik 2.14.2? |
|
I just upgraded both piwik and plugin to 2.14.2 and 0.1.7 this morning and this is working. Thanks a lot! 🍻 |
|
Thx! I haven't tested with Piwik 2.14.0 so I'm not sure whether plugin will work with that version. I'll release a new version 0.1.8 that requires Piwik 2.14.2 just to make sure it'll work |
Use Environment instance instead of trying to clear the container and reload tracker plugins / environment in-place.
Should fix #12
@tsteur Can you test these changes? I'm not currently setup to test/debug QueuedTracking and there aren't any automated tests for this command. Feel free to commit directly to this branch, you'd know better how to apply this change to this plugin.