Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI test screenshots adding top of datatable controls #56

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

michalkleiner
Copy link
Contributor

Description:

This is a plugin PR related to matomo-org/matomo#22827 where we are adding a second set of data table controls at the top of the report for all visualisation types, apart from when it's within a dashboard.

In some of the screenshots the change looks like the controls are touching the edge or even overflowing, but that is just due to what area of the UI is selected for the screenshot. As you can see when it's in place in the UI, that doesn't occur.

Ref DEV-13900

Review

@michalkleiner michalkleiner requested a review from a team December 20, 2024 15:36
@michalkleiner
Copy link
Contributor Author

The UI tests will fail until the core change is merged. Then we need to merge the plugin PR and update submodules in core after that.

@sgiehl sgiehl force-pushed the dev-13900-table-controls branch from 41af35f to 2eea4d7 Compare January 17, 2025 08:41
@sgiehl sgiehl merged commit 022ca1c into 5.x-dev Jan 17, 2025
6 checks passed
@sgiehl sgiehl deleted the dev-13900-table-controls branch January 17, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants