Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nbconvert pdf export #404

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Fix nbconvert pdf export #404

merged 1 commit into from
Dec 13, 2021

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Dec 13, 2021 •
edited
Loading

Fix #403

When exporting to pdf, the only mimetype that makes sense is the image/png one, so we need it around.

@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch martinRenou/ipympl/fix_nbconvert_pdf_export

@martinRenou martinRenou merged commit 84bf0aa into matplotlib:master Dec 13, 2021
@martinRenou martinRenou deleted the fix_nbconvert_pdf_export branch December 13, 2021 15:43
@tovrstra
Copy link

Thanks for the quick fix!! (I've also tested it locally and the fix works.)

@martinRenou
Copy link
Member Author

Thanks for trying :)

I see another issue on the HTML export with nbconvert. I'm trying to push a fix for that too and should release 0.8.3.

@martinRenou martinRenou mentioned this pull request Dec 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export with nbconvert to PDF only shows figures with display(fig) [ipympl-0.8.2]
2 participants
@martinRenou @tovrstra