Build using JupyterLab 4 #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ianthomas23
force-pushed
the
build_using_jlab4
branch
from
c62d4ac
to
fadf80f
Compare
|
I've removed the captions above the Matplotlib figures otherwise slight differences in rendering between ubuntu and macos cause the image comparison tests to fail. These captions are in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #539.
This changes the build system to build against JupyterLab 4 rather than 3. I have manually checked that the wheel generated in this way works on all the following:
Note that
ipymplalready worked fine on JupyterLab 4, this just modernises the build process.