-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factor out common code between pdf and ps backends. #9867
Conversation
fc50040
to
2ddaed9
Compare
Something is wrong w/ py 2.7 figures. |
2ddaed9
to
fc38575
Compare
forgot to future-import division :p |
appveyor seems to have picked up a bug. Both your recent PRs have it.... |
Seems unrelated, tbh... |
No I agree, it has nothing to do w/ your PRs, but I suspect a bug was recently introduced into Master |
The last build to pass had pytest 3.2.5; this one has 3.3.0. There was a similar bug in 3.2.1: pytest-dev/pytest#2644 but maybe there was a regression. |
New report is at pytest-dev/pytest#2957. |
04546a2
to
117acd0
Compare
117acd0
to
479fba8
Compare
This seems like a useful re-factor. It could use a second review... ping @tacaswell @jkseppan |
rebased Additionally merged the implementations of get_canvas_width_height, with the following addition to the commit message:
|
3460602
to
899939b
Compare
(The AFM cache only needs to cache on filename, not on font properties, because the fontprop->filename conversion is already cached by font_manager. get_canvas_width_height can be merged because FigureCanvasPdf always makes sure to call newPage(width, height) and create a new RendererPdf with the same width and height, and it's likely other things break if the PdfFile and the Renderer's size don't match anyways.
thanks |
Thank you! |
(The AFM cache only needs to cache on filename, not on font properties,
because the fontprop->filename conversion is already cached by
font_manager.)
PR Summary
PR Checklist