-
Notifications
You must be signed in to change notification settings - Fork 22
Fig test slice #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fig test slice #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is now skipped during testing, and it shouldn't be skipped. (e.g. see https://github.com/matplotlib/napari-matplotlib/actions/runs/4981454254/jobs/8915726820?pr=113#step:7:42)
I suspect this is because there aren't any baseline images? Instead of gitignoring the test image folder, I think we decided to upload the test images to the repo, so the gitignore needs changing, and the baseline test images adding.
Locally it seems to skip the first time when creating the baseline image and then it works as expected the 2nd time, but clearly is not the case for tox so will investigate further. Yes, I remember now and I've found a 3D image that works then makes sense to remove from gitignore. |
👍 - I think the two things that need doing then are:
|
…ore for baseline folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is still being skipped, I'm guessing because it still isn't finding the test image?
Yes, I've not got it quite working yet as using tox locally, the test_slice is being skipped due to |
@dstansby Turns out |
Towards #8