Skip to content

Add reports from pytest-mpl, changed setup and tox #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 19, 2023

Conversation

ruaridhg
Copy link
Collaborator

@ruaridhg ruaridhg commented May 19, 2023

Closes #97

  • 2D and 3D pytest-mpl reports added for histogram and slice with html summary fig_comparison.html
  • matplotlib added to setup.cfg testing
  • cp and ls commands added to tox and mpl-result-path set in tox

@ruaridhg ruaridhg requested a review from dstansby May 19, 2023 12:09
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to commit an individual report from a test run to the repository - the report should be generated during testing (either locally or on GitHub actions), and then we want to upload that as an artefact at the end of the GitHub actions run.

So I think the TODO here is (let me know if this doesn't make sense or you think otherwise!):

  • Undo adding the report directory, and put back report in gitignore
  • Add a step at the end of the GH actions run that uploads the whole report directory using actions/upload-artifact

@ruaridhg
Copy link
Collaborator Author

We don't want to commit an individual report from a test run to the repository - the report should be generated during testing (either locally or on GitHub actions), and then we want to upload that as an artefact at the end of the GitHub actions run.

So I think the TODO here is (let me know if this doesn't make sense or you think otherwise!):

  • Undo adding the report directory, and put back report in gitignore
  • Add a step at the end of the GH actions run that uploads the whole report directory using actions/upload-artifact

I was actually just thinking the same thing so will add the upload-artifact step

Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice, looking good!
Screenshot 2023-05-19 at 16 54 28

@dstansby dstansby added this pull request to the merge queue May 19, 2023
Merged via the queue into matplotlib:main with commit 231d77d May 19, 2023
@dstansby dstansby added the Tests label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest-mpl report out from tox and upload it as a build artefact in the CI
2 participants