Skip to content

Update plugin metadata #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 2, 2023
Merged

Update plugin metadata #145

merged 3 commits into from
Jun 2, 2023

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Jun 1, 2023 •
edited
Loading

Fixes #126

@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Jun 1, 2023 •
edited
Loading

Preview page for your plugin is ready here:
https://preview.napari-hub.org/matplotlib/napari-matplotlib/145
Updated: 2023-06-01T10:40:52.516091

@dstansby dstansby changed the title Bump napari-hub previous action versions Update plugin metadata Jun 1, 2023
@dstansby dstansby requested review from samcunliffe and ruaridhg June 1, 2023 10:58
dstansby
dstansby commented Jun 1, 2023
View reviewed changes
.napari/DESCRIPTION.md
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this because napari hub pulls the description form PyPI by deafult, so this is not needed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for minimising duplication but we get:

Screenshot 2023-06-01 at 14 49 17

Could you symlink it to README?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's going on there, it shows up fine on the actual released version 🤔 https://www.napari-hub.org/plugins/napari-matplotlib

ruaridhg
ruaridhg approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@ruaridhg ruaridhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dstansby dstansby marked this pull request as ready for review June 1, 2023 11:07
@dstansby
Copy link
Member Author

dstansby commented Jun 2, 2023

In order to avoid faffing around to work out what's going on with the preview build, I'm going to merge this, and then double check the description appears correctly when I do a new release later.

@dstansby dstansby added this pull request to the merge queue Jun 2, 2023
Merged via the queue into matplotlib:main with commit 9e540ec Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruaridhg ruaridhg ruaridhg approved these changes

@samcunliffe samcunliffe Awaiting requested review from samcunliffe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check and review plugin entry on napari hub
3 participants
@dstansby @samcunliffe @ruaridhg