Skip to content

3D scatter test #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 2, 2023
Merged

3D scatter test #152

merged 8 commits into from
Jun 2, 2023

Conversation

ruaridhg
Copy link
Collaborator

@ruaridhg ruaridhg commented Jun 2, 2023

Closes #8

  • Added test_scatter_3D with brain_data
  • Changed slice number to 9 so it was different from default to check test

Potential remaining tasks (@dstansby):

  • Should I switch the default slice number for the 3D histogram and 3D slice tests?
  • Not sure how to implement a 3D features scatter (is this necessary?)

@dstansby
Copy link
Member

dstansby commented Jun 2, 2023

Should I switch the default slice number for the 3D histogram and 3D slice tests?

Do you think there's a benefit to doing this (e.g. is it testing something that wouldn't be tested if the slice isn't changed)? If so I'd say go for it!

Not sure how to implement a 3D features scatter (is this necessary?)

I think features data is always 2D, so we don't have to worry about 3D tests for that.

@ruaridhg ruaridhg enabled auto-merge June 2, 2023 13:28
@ruaridhg ruaridhg requested a review from dstansby June 2, 2023 14:04
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • One comment to remove
  • Isn't brain_data[0] an array already, so it shouldn't need casting to an array?

@ruaridhg ruaridhg requested a review from dstansby June 2, 2023 14:29
@ruaridhg ruaridhg added this pull request to the merge queue Jun 2, 2023
Merged via the queue into matplotlib:main with commit 7f675f2 Jun 2, 2023
@ruaridhg ruaridhg deleted the scatter-test-3D-data branch June 2, 2023 14:53
@dstansby dstansby added the Tests label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test with 2D and 3D data
2 participants