-
Notifications
You must be signed in to change notification settings - Fork 22
3D scatter test #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3D scatter test #152
Conversation
Do you think there's a benefit to doing this (e.g. is it testing something that wouldn't be tested if the slice isn't changed)? If so I'd say go for it!
I think features data is always 2D, so we don't have to worry about 3D tests for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- One comment to remove
- Isn't
brain_data[0]
an array already, so it shouldn't need casting to an array?
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
Closes #8
Potential remaining tasks (@dstansby):