-
Notifications
You must be signed in to change notification settings - Fork 22
added colorsetting function #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor changes, and a suggestion for iterating through the spines. Otherwise looking 👍 (and sorry about how long it's taken me to get to this, if you want me to finish this off just let me know!)
Ooh also a rebase would be good to check that |
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks 👍 - not sure this does fix #36, as there hasn't been a matplotlibrc
file added. That's fine for now, but I'll make sure that issue doesn't get closed when I merge this 😄
Fixes #64
I added a function to the plot base class that applies the functions pointed out by @haesleinhuepf in this discussion. The function can then called whenever the
self.axes
object has been created in any plot class that was derived from the main class.I put it as a draft PR since there are no tests yet. Also I think that it could be mentioned in the contribution guidelines that new widgets should call this method after
self.canvas.figure.add_subplot()
has been called.Let me know what you think :)