Skip to content

added colorsetting function #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 2, 2023

Conversation

jo-mueller
Copy link
Contributor

@jo-mueller jo-mueller commented Feb 13, 2023

Fixes #64

I added a function to the plot base class that applies the functions pointed out by @haesleinhuepf in this discussion. The function can then called whenever the self.axes object has been created in any plot class that was derived from the main class.

I put it as a draft PR since there are no tests yet. Also I think that it could be mentioned in the contribution guidelines that new widgets should call this method after self.canvas.figure.add_subplot() has been called.

Let me know what you think :)

@jo-mueller jo-mueller marked this pull request as ready for review March 3, 2023 08:59
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor changes, and a suggestion for iterating through the spines. Otherwise looking 👍 (and sorry about how long it's taken me to get to this, if you want me to finish this off just let me know!)

@dstansby
Copy link
Member

Ooh also a rebase would be good to check that pre-commit is happy!

@jo-mueller
Copy link
Contributor Author

jo-mueller commented May 2, 2023

Hi @dstansby ,

thanks for the feedback, I incorporated your suggestions. The last commit was me not realizing that set_tight_layout() had been deprecated when I rebased my branch ^^"

PS: I edited the PR message so that both #36 and #64 will be closed by this PR as they both address the same issue.

Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 👍 - not sure this does fix #36, as there hasn't been a matplotlibrc file added. That's fine for now, but I'll make sure that issue doesn't get closed when I merge this 😄

@dstansby dstansby added this to the 0.3.0 milestone May 2, 2023
@dstansby dstansby merged commit e1d3c50 into matplotlib:main May 2, 2023
@jo-mueller jo-mueller deleted the fix-default-colorscheme branch May 3, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

importing napari-matplotlib modifies how plots are shown in jupyter notebooks
2 participants