Skip to content

Added qt_api in pytest.ini and commented out error in filterwarnings #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2023
Merged

Added qt_api in pytest.ini and commented out error in filterwarnings #91

merged 2 commits into from
May 5, 2023

Conversation

ruaridhg
Copy link
Collaborator

@ruaridhg ruaridhg commented May 5, 2023

Had to pip install pytest-qtbot and then set the qt_api=pyqt5 for the tests to work as indeed
Also commenting out error in filterwarnings was necessary.

@ruaridhg ruaridhg requested review from samcunliffe and dstansby May 5, 2023 14:39
dstansby
dstansby requested changes May 5, 2023
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely leave in the error line. If there are specific warnings you're getting, they should be individually filtered out like the line at the bottom of this file.

@ruaridhg
Copy link
Collaborator Author

ruaridhg commented May 5, 2023

We should definitely leave in the error line. If there are specific warnings you're getting, they should be individually filtered out like the line at the bottom of this file.

Fair enough, I've made those changes now in the latest commit

@ruaridhg ruaridhg requested a review from dstansby May 5, 2023 15:00
@dstansby dstansby added this pull request to the merge queue May 5, 2023
Merged via the queue into matplotlib:main with commit ece6934 May 5, 2023
@ruaridhg ruaridhg deleted the fix_pytest_ini branch May 5, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

@samcunliffe samcunliffe Awaiting requested review from samcunliffe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruaridhg @dstansby