Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified MatrixBus API #22

Open
wants to merge 1 commit into
base: no_std
Choose a base branch
from
Open

Simplified MatrixBus API #22

wants to merge 1 commit into from

Conversation

jeikabu
Copy link
Contributor

@jeikabu jeikabu commented May 9, 2020

  • Move address parameter to MatrixBus trait, impls are now responsible for packing/formatting as required by the platform
  • esp32_everloop example uses ESP-IDF v3.3 and must use older esp_idf_build
  • Tested on Voice using kernel module and ESP32

@jeikabu
Simplified MatrixBus API
3e5901e 
- Move address parameter to MatrixBus trait, impls are now responsible for packing/formatting as required by the platform
- esp32_everloop example uses ESP-IDF v3.3 and must use older esp_idf_build
- Tested on Voice using kernel module and ESP32
jeikabu
jeikabu commented May 9, 2020
View reviewed changes
Copy link
Contributor Author

@jeikabu jeikabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main omissions:

  • Testing Creator's additional sensors (I lack the hardware)
  • Doc/comment updates; would prefer to wait until the API looks more "final"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeikabu