Skip to content

Commit

Permalink
sign-off: Fix link and add format advice (#11)
Browse files Browse the repository at this point in the history
As found in matrix-org/matrix-hookshot#430, the linkifying in GitHub included the `.` and so the anchor didn't work.

Also, it turns out people sometimes miss the format we expect and do their own thing. Rather than trying to make the regex even more lenient, I'd rather just suggest the format we expect explicitly.
  • Loading branch information
Half-Shot authored Aug 1, 2022
1 parent 33ab6ec commit 0c5c0a7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/sign-off.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,6 @@ jobs:
return;
}
core.setFailed('No sign off found. Please ensure you have signed off following the advice in https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off.')
core.setFailed('No sign off found. Please ensure you have signed off following the advice in https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off .')
core.notice('Ensure you have matched the format `Signed-off-by: Your Name <your@email.example.org>`')
core.notice('If you have signed off privately instead (following the steps in Private Sign off), you can ignore this test.')

0 comments on commit 0c5c0a7

Please sign in to comment.