Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to tests for restricted rooms based on changes to MSC3083. #145

Merged
merged 8 commits into from
Jul 26, 2021
Merged

Updates to tests for restricted rooms based on changes to MSC3083. #145

merged 8 commits into from
Jul 26, 2021

Conversation

clokep
Copy link
Member

@clokep clokep commented Jul 1, 2021

Corresponds to matrix-org/synapse#10254:

  • Updates the room version identifier.
  • Additional tests for the authorised server changes in the MSC.

@clokep clokep marked this pull request as draft July 1, 2021 17:07
@clokep clokep mentioned this pull request Jul 1, 2021
Merged
@clokep clokep marked this pull request as ready for review July 20, 2021 12:44
@clokep clokep requested a review from a team July 20, 2021 12:50
@babolivier babolivier self-assigned this Jul 21, 2021
babolivier
babolivier approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@babolivier babolivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more details needed in comments but otherwise lgtm

tests/msc3083_test.go Outdated Show resolved Hide resolved
tests/msc3083_test.go Outdated Show resolved Hide resolved
@clokep
Copy link
Member Author

clokep commented Jul 21, 2021

Thanks! I also updated the overall comment for the test since it was quite confusing.

@clokep clokep mentioned this pull request Jul 22, 2021
Merged
@clokep clokep mentioned this pull request Jul 26, 2021
Merged
@clokep clokep merged commit e9e86d3 into master Jul 26, 2021
@clokep clokep deleted the clokep/restricted-auth branch July 26, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babolivier babolivier babolivier approved these changes

Assignees

@babolivier babolivier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clokep @babolivier