Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account data: add test for setting and getting #575

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

sumnerevans
Copy link
Contributor

This PR adds tests for getting and setting account data.

The tests correspond to the following sytest tests:

  • Can add account data
  • Can get account data without syncing
  • Can add account data to room
  • Can get room account data without syncing

Signed-off-by: Sumner Evans sumner@beeper.com

@sumnerevans sumnerevans requested review from a team and kegsay as code owners December 21, 2022 04:30
@sumnerevans
Copy link
Contributor Author

looks like possibly some overlap with #574 with regards to the internal client functions

@anoadragon453
Copy link
Member

anoadragon453 commented Jan 1, 2023

looks like possibly some overlap with #574 with regards to the internal client functions

Heads up that #574 has now merged.

tests/csapi/account_data_test.go Outdated Show resolved Hide resolved
tests/csapi/account_data_test.go Outdated Show resolved Hide resolved
@sumnerevans sumnerevans force-pushed the account-data-tests branch 2 times, most recently from 4feb227 to 106b8d7 Compare January 4, 2023 18:32
@DMRobertson DMRobertson requested review from a team and anoadragon453 February 6, 2023 18:22
Signed-off-by: Sumner Evans <sumner@beeper.com>
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@squahtx squahtx merged commit f4a938e into matrix-org:main Feb 7, 2023
@sumnerevans sumnerevans deleted the account-data-tests branch February 7, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants