-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for eager-sync behaviour during and after a partial join #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dummy amend to retrigger CI
DMRobertson
force-pushed
the
dmr/eager-syncs-faster-joins
branch
from
January 19, 2023 14:54
a19e095
to
cb46edc
Compare
This reverts commit 84c8878.
fuck you golang
idk why golang makes these hard to see in test output
Co-authored-by: Mathieu Velten <mathieuv@matrix.org>
DMRobertson
changed the title
Dmr/eager syncs faster joins
Tests for eager-sync behaviour during and after a partial join
Jan 20, 2023
squahtx
reviewed
Jan 20, 2023
DMRobertson
force-pushed
the
dmr/eager-syncs-faster-joins
branch
from
January 23, 2023 16:48
8301105
to
76d2e5c
Compare
As with the branch this tests, if CI passes I'm inclined to merge given that Sean is away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #584 by @MatMaul.
Matches matrix-org/synapse#14870