Fix TestRestrictedRoomsRemoteJoinFailOver flake due to race
#614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `TestRestrictedRoomsRemoteJoinFailOver` test involves a leave, then rejoin of a restricted room over federation. Ensure that the remote homeserver has processed the leave event before trying to rejoin, otherwise the test will not be testing the intended behaviour. Signed-off-by: Sean Quah <seanq@matrix.org>
DMRobertson
approved these changes
Feb 16, 2023
squahtx
deleted the
squah/deflake_restricted_rooms_remote_join_failover
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TestRestrictedRoomsRemoteJoinFailOvertest involves a leave, thenrejoin of a restricted room over federation. Ensure that the remote
homeserver has processed the leave event before trying to rejoin,
otherwise the test will not be testing the intended behaviour.
Signed-off-by: Sean Quah seanq@matrix.org
Fixes matrix-org/synapse#14986.