Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the post script _before_ killing the containers #707

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Jan 30, 2024

It's not very useful having the container ID otherwise..

@kegsay kegsay added the bug Something isn't working label Jan 30, 2024
@kegsay kegsay requested a review from S7evinK January 30, 2024 17:51
@kegsay kegsay requested review from a team as code owners January 30, 2024 17:51
@S7evinK
Copy link
Contributor

S7evinK commented Mar 19, 2024

Maybe should have added the reason why it is like this here as well when @kegsay asked for a review:
The current approach makes sure that e.g. Dendrite is shutdown cleanly before attempting to pull out coverage data, which is only flushed out to disk on a clean shutdown (that's also why complementRuntime.ContainerKillFunc is a thing). Moving this up makes this now unusable for this use case.

I understand why it may be moved up, but this breaks coverage reporting for Dendrite.

From my perspective, we need both use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants