Add test for shared history visibility over federation #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // - Bob leaves the room. | ||
| // - Alice sends a message. | ||
| // - Bob joins the room. | ||
| // - The next sync response should include a timeline which ends with [BOB_LEAVE, ALICE_MSG, BOB_JOIN]. |
There was a problem hiding this comment.
I think it would be perfectly valid to return just BOB_JOIN here, which I thought we did
| t.Logf("timeline => %v", timeline.Raw) | ||
| timelineArray := timeline.Array() | ||
| must.NotEqual(t, len(timelineArray), 0, "no timeline for room "+roomID) | ||
| must.Equal(t, len(timelineArray) >= 3, true, "need at least 3 timeline events for the room") |
There was a problem hiding this comment.
This doesn't print the number of events there are, which makes seeing how Synapse is failing hard
There was a problem hiding this comment.
The raw timeline is logged on :289 which seems to be nothing:
2024-03-05T17:36:31.3391923Z client.go:631: [CSAPI] GET hs2/_matrix/client/v3/sync => 200 OK (21.832274ms)
2024-03-05T17:36:31.3392485Z federation_room_send_test.go:289: timeline =>
2024-03-05T17:36:31.3393366Z federation_room_send_test.go:291: �[31mNotEqual no timeline for room !mmzAHLfjZSvFNZKCgv:hs1: got '0', want '0'�[39m
2024-03-05T17:36:31.3394808Z federation_room_send_test.go:292: �[31mEqual need at least 3 timeline events for the room: got 'false' want 'true'�[39m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently fails on Synapse.