Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Peeking via MSC2753 #1370

Merged
merged 66 commits into from
Sep 10, 2020
Merged

Peeking via MSC2753 #1370

merged 66 commits into from
Sep 10, 2020

Commits on Aug 30, 2020

  1. a very very WIP first cut of peeking via MSC2753. 

    doesn't yet compile or work.
needs to actually add the peeking block into the sync response.
checking in now before it gets any bigger, and to gather any initial feedback on the vague shape of it.
    @ara4n
    ara4n committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    b9342d9 View commit details
    Browse the repository at this point in the history

  2. make PeekingDeviceSet private

    @ara4n
    ara4n committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    d7bdf71 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. merge master

    @ara4n
    ara4n committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    cfa0be5 View commit details
    Browse the repository at this point in the history

  2. add server_name param

    @ara4n
    ara4n committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    9b79f9a View commit details
    Browse the repository at this point in the history

  3. blind stab at adding a peek section to /sync

    @ara4n
    ara4n committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    d343b8f View commit details
    Browse the repository at this point in the history

  4. make it build

    @ara4n
    ara4n committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    c4e5f60 View commit details
    Browse the repository at this point in the history

  5. make it launch

    @ara4n
    ara4n committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    d1e4d66 View commit details
    Browse the repository at this point in the history

  6. add peeking to getResponseWithPDUsForCompleteSync

    @ara4n
    ara4n committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    f006b37 View commit details
    Browse the repository at this point in the history

  7. cancel any peeks when we join a room

    @ara4n
    ara4n committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    6c3a896 View commit details
    Browse the repository at this point in the history

  8. spell out how to runoutside of docker if you want speed

    @ara4n
    ara4n committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    7b38d48 View commit details
    Browse the repository at this point in the history

  9. fix SQL

    @ara4n
    ara4n committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    e589984 View commit details
    Browse the repository at this point in the history

  10. remove unnecessary txn for SelectPeeks

    @ara4n
    ara4n committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    0bb2c2c View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. Merge branch 'master' into matthew/peeking

    @ara4n
    ara4n committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    28219c6 View commit details
    Browse the repository at this point in the history

  2. fix s/join/peek/ cargocult fail

    @ara4n
    ara4n committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    86e9736 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into matthew/peeking

    @ara4n
    ara4n committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    d0d5f70 View commit details
    Browse the repository at this point in the history

  4. HACK: Track goroutine IDs to determine when we write by the wrong thread 

    To use: set `DENDRITE_TRACE_SQL=1` then grep for `unsafe`
    @kegsay
    kegsay committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    bfecc8e View commit details
    Browse the repository at this point in the history

  5. Track partition offsets and only log unsafe for non-selects

    @kegsay
    kegsay committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    7bf2a27 View commit details
    Browse the repository at this point in the history

  6. Put redactions in the writer goroutine

    @kegsay
    kegsay committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    fcdb90c View commit details
    Browse the repository at this point in the history

  7. Update filters on writer goroutine

    @kegsay
    kegsay committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    6410b70 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'kegan/redact-txn' into matthew/peeking

    @ara4n
    ara4n committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    ed4b3a5 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'kegan/HACK-goid-sqlite-db-is-locked' into matthew/peeking

    @ara4n
    ara4n committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    3cebd8d View commit details
    Browse the repository at this point in the history

  10. wrap peek storage in goid hack

    @ara4n
    ara4n committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    5d7f688 View commit details
    Browse the repository at this point in the history

  11. use exclusive writer, and MarkPeeksAsOld more efficiently

    @ara4n
    ara4n committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    6424117 View commit details
    Browse the repository at this point in the history

  12. don't log ascii in binary at sql trace...

    @ara4n
    ara4n committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    85bce11 View commit details
    Browse the repository at this point in the history

  13. strip out empty roomd deltas

    @ara4n
    ara4n committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    75b91ac View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. re-add txn to SelectPeeks

    @ara4n
    ara4n committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    b6cc441 View commit details
    Browse the repository at this point in the history

  2. re-add accidentally deleted field

    @ara4n
    ara4n committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    f6af656 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Merge branch 'master' into matthew/peeking

    @ara4n
    ara4n committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    8712ea3 View commit details
    Browse the repository at this point in the history

  2. reject peeks for non-worldreadable rooms

    @ara4n
    ara4n committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    eda84cd View commit details
    Browse the repository at this point in the history

  3. move perform_peek

    @ara4n
    ara4n committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    da3742c View commit details
    Browse the repository at this point in the history

  4. fix package

    @ara4n
    ara4n committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    3c5e079 View commit details
    Browse the repository at this point in the history

  5. correctly refactor perform_peek

    @ara4n
    ara4n committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    c775643 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into matthew/peeking

    @ara4n
    ara4n authored Sep 3, 2020
    Configuration menu
    Copy the full SHA
    4f5c8ca View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Merge branch 'master' into matthew/peeking

    @neilalexander
    neilalexander committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    2b8f0b8 View commit details
    Browse the repository at this point in the history

  2. Cancel peeks on join again

    @neilalexander
    neilalexander committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    56d772f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into matthew/peeking

    @neilalexander
    neilalexander committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    9ad05e7 View commit details
    Browse the repository at this point in the history

  4. Fix unit test

    @neilalexander
    neilalexander committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    ca0406e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into matthew/peeking

    @neilalexander
    neilalexander authored Sep 4, 2020
    Configuration menu
    Copy the full SHA
    83c559c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into matthew/peeking

    @neilalexander
    neilalexander committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    64fe274 View commit details
    Browse the repository at this point in the history

  7. Add PerformPeek full-HTTP serverside

    @neilalexander
    neilalexander committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    5c04c52 View commit details
    Browse the repository at this point in the history

  8. Revert "Merge branch 'kegan/HACK-goid-sqlite-db-is-locked' into matth… 

    …ew/peeking"

This reverts commit 3cebd8d, reversing
changes made to ed4b3a5.
    @neilalexander
    neilalexander committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    ff65f0e View commit details
    Browse the repository at this point in the history

  9. Clear a whole bunch of lint issues

    @neilalexander
    neilalexander committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    2ccd4fa View commit details
    Browse the repository at this point in the history

  10. Merge branch 'matthew/peeking' of github.com:matrix-org/dendrite into… 

    … matthew/peeking
    @neilalexander
    neilalexander committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    8bbccab View commit details
    Browse the repository at this point in the history

  11. Fix PerformPeekPath

    @neilalexander
    neilalexander committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    843b7a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2020

  1. add (broken) postgres; advance streampos whenever sync output changes

    @ara4n
    ara4n committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    55c7f2c View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. move peek-cancelling to consumer

    @ara4n
    ara4n committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    034ff32 View commit details
    Browse the repository at this point in the history

  2. remove erroneous commentary

    @ara4n
    ara4n committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    7f41f39 View commit details
    Browse the repository at this point in the history

  3. (broken) rewrite to use SelectPeeksInRange rather than MarkPeeksAsOld… 

    … for idempotency
    @ara4n
    ara4n committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    9f2bc62 View commit details
    Browse the repository at this point in the history

  4. track transitions more clearly

    @ara4n
    ara4n committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    b96a31d View commit details
    Browse the repository at this point in the history

  5. notify new streampos after joining peeked rooms

    @ara4n
    ara4n committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    7a76f49 View commit details
    Browse the repository at this point in the history

  6. Only call Membership() on membership events

    @neilalexander
    neilalexander committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    56001d0 View commit details
    Browse the repository at this point in the history

  7. Don't return sql.ErrNoRows on DeletePeeks since that is not an error … 

    …condition
    @neilalexander
    neilalexander committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    6fe281a View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into matthew/peeking

    @neilalexander
    neilalexander committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    bcbe651 View commit details
    Browse the repository at this point in the history

  9. Don't panic

    @neilalexander
    neilalexander committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    faa070b View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. fix nightmare bug where sqlite doesn't let you use out of order sub s… 

    …trings
    @ara4n
    ara4n committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    de53608 View commit details
    Browse the repository at this point in the history

  2. handle exclusive writer txn for cleanliness

    @ara4n
    ara4n committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    b45436a View commit details
    Browse the repository at this point in the history

  3. go fmt

    @ara4n
    ara4n committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    052351e View commit details
    Browse the repository at this point in the history

  4. fix lint

    @ara4n
    ara4n committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    2300549 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into matthew/peeking

    @ara4n
    ara4n authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    d2a0bad View commit details
    Browse the repository at this point in the history

  6. Remove accidental formerly-untracked file

    @neilalexander
    neilalexander committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    f09afe0 View commit details
    Browse the repository at this point in the history

  7. Return errors from SQL statements to handle rollbacks correctly

    @kegsay
    kegsay committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    15349d8 View commit details
    Browse the repository at this point in the history

  8. Fix sqlite DeletePeeks API to match postgres; fix bug which incorrect… 

    …ly altered sp when nothing is deleted
    @kegsay
    kegsay committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    34b8961 View commit details
    Browse the repository at this point in the history

  9. Add peeking tests to whitelist

    @kegsay
    kegsay committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    af47237 View commit details
    Browse the repository at this point in the history

  10. fix lots of places where we didn't rollback txns upon go errs (#1417) 

    Co-authored-by: Kegan Dougal <kegan@matrix.org>
    @ara4n @kegsay
    ara4n and kegsay authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    8cec7e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. allow duplicate stream ids in the peeks table

    @ara4n
    ara4n committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    b1d1ccd View commit details
    Browse the repository at this point in the history

  2. stop the peek table growing by reusing rows correctly

    @ara4n
    ara4n committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    9561843 View commit details
    Browse the repository at this point in the history