Preparations for removing BaseDendrite
#3016
Conversation
S7evinK
added
the
T-Task
S7evinK
changed the title
BaseDendrite
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3016 +/- ##
==========================================
+ Coverage 63.04% 63.15% +0.10%
==========================================
Files 496 497 +1
Lines 53837 53843 +6
==========================================
+ Hits 33944 34003 +59
+ Misses 16173 16115 -58
- Partials 3720 3725 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 46 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| // Create required internal APIs | ||
| rsAPI := roomserver.NewInternalAPI(base) | ||
| rsAPI := roomserver.NewInternalAPI(base, caches) |
There was a problem hiding this comment.
I assume the idea is unpick base from this entirely, and adding caches is just a step towards that?
There was a problem hiding this comment.
Indeed, that is the idea. Gradually remove the need for base.
| httpRouter.PathPrefix(httputil.PublicClientPathPrefix).Handler(base.PublicClientAPIMux) | ||
| httpRouter.PathPrefix(httputil.PublicMediaPathPrefix).Handler(base.PublicMediaAPIMux) | ||
| httpRouter.PathPrefix(httputil.PublicClientPathPrefix).Handler(base.Routers.Client) | ||
| httpRouter.PathPrefix(httputil.PublicMediaPathPrefix).Handler(base.Routers.Media) |
There was a problem hiding this comment.
Amazing names, much much better now we have no private APIs 😍
| go func() { | ||
| <-ctx.Done() | ||
| _ = fts.Close() | ||
| }() |
| "net/url" | ||
|
|
||
| "github.com/gorilla/mux" |
There was a problem hiding this comment.
As a side note, do we have an issue to replace mux? We need to as it has been archived and isn't maintained anymore.
| ) | ||
|
|
||
| type ConnectionManager interface { | ||
| Connection(dbProperties *config.DatabaseOptions) (*sql.DB, Writer, error) |
There was a problem hiding this comment.
Not sure I see the value in interfacing this? Any concrete impl would need to return a DB which is pretty difficult to mock out!
Preparations to actually remove/replace
BaseDendrite.Quite a few changes:
fulltext.Indexerinterface (fulltext is removed fromBaseDendrite)BaseDendriteRouterstruct (likely to change)sqlutil.ConnectionManager, which should removebase.DatabaseConnectionlater on