Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Return M_INVALID_PARAM instead of M_BAD_JSON when setting aliases #3297

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Jan 9, 2024

Part of #3223 (matrix-org/matrix-spec#1286)

(For DELETE we don't validate the alias, but just return a 404 if we can't find it)

@S7evinK S7evinK added the spec-compliance Fix something that doesn't comply with the specs label Jan 9, 2024
@S7evinK S7evinK requested a review from a team as a code owner January 9, 2024 18:42
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (13c5173) 65.37% compared to head (f5bb010) 65.35%.

Files Patch % Lines
clientapi/routing/directory.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3297      +/-   ##
==========================================
- Coverage   65.37%   65.35%   -0.03%     
==========================================
  Files         509      509              
  Lines       57471    57471              
==========================================
- Hits        37573    37560      -13     
- Misses      16006    16019      +13     
  Partials     3892     3892              
Flag Coverage Δ
unittests 50.01% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK merged commit 9510fa0 into main Jan 9, 2024
16 of 20 checks passed
@S7evinK S7evinK deleted the s7evink/return-invalid-param branch January 9, 2024 19:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
spec-compliance Fix something that doesn't comply with the specs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants