Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function signature, use default random boundary #3422

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Sep 12, 2024

Fixes the function signature of parseMultipartResponse and uses the default random boundary when creating a new multipart response.

@S7evinK S7evinK requested a review from a team as a code owner September 12, 2024 18:11
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.28%. Comparing base (002fed3) to head (ecf5a95).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
mediaapi/routing/download.go 33.33% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3422      +/-   ##
==========================================
- Coverage   68.30%   68.28%   -0.02%     
==========================================
  Files         513      513              
  Lines       47029    47026       -3     
==========================================
- Hits        32123    32114       -9     
- Misses      10909    10913       +4     
- Partials     3997     3999       +2     
Flag Coverage Δ
unittests 53.29% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK merged commit ed6d964 into main Sep 13, 2024
19 of 20 checks passed
@S7evinK S7evinK deleted the s7evink/multipart-sig branch September 13, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant