Update for compatibility with Python 3.11 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's debatable whether this check is even still needed, but for now let's do the simple thing and update it to be compatible with modern Python versions.
MatMaul
approved these changes
Jan 3, 2023
|
Thanks for the review @MatMaul! I'm going to keep the changes on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dh-virtualenvis a tool that packages Python dependencies from PyPI into debian packages and run with the installee system's Python interpreter.dh-virtualenvrelied on theinspect.getargspecmethod, which has been deprecated since Python 3.0. Finally, it appears that this method has been removed in Python 3.11.x, which Debian sid ships with. This caused Synapse's deb builds for Debian sid to fail.This PR updates the check to use
inspect.getfullargspecinstead, which is the suggested replacement.It's debatable whether this check is even still needed, but for now let's do the simple thing and update it to be compatible with modern Python versions.