Default PowerLevelContent.Invite to 0 per matrix spec #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
|
Can you take a look at the failing tests please? |
The default power level for invite was wrong in matrix spec v1.1[1], and has been fixed in v1.3, bringing us in line with synase[2]. [1] matrix-org/matrix-spec@136b5c9 [2] https://github.com/matrix-org/synapse/blob/v1.92.3/synapse/handlers/event_auth.py#L138 Signed-off-by: Nick Cao <nickcao@nichi.co>
Solved. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
- Coverage 58.76% 58.73% -0.03%
==========================================
Files 51 51
Lines 7098 7098
==========================================
- Hits 4171 4169 -2
- Misses 2536 2538 +2
Partials 391 391
☔ View full report in Codecov by Sentry. |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default power level for invite was wrong in matrix spec v1.1[1], and has been fixed in v1.3, bringing us in line with synase[2].
[1] matrix-org/matrix-spec@136b5c9
[2] https://github.com/matrix-org/synapse/blob/v1.92.3/synapse/handlers/event_auth.py#L138
Pull Request Checklist
Signed-off-by:
Nick Cao <nickcao@nichi.co>