Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Room Tag Comparator : use a separate class and probably fix a crash #333

Merged
merged 2 commits into from
Aug 8, 2018

Conversation

ganfra
Copy link
Contributor

@ganfra ganfra commented Aug 8, 2018

@ganfra ganfra requested a review from bmarty August 8, 2018 12:36
@bmarty
Copy link
Contributor

bmarty commented Aug 8, 2018

Notes: tests fails but it's not related to this PR. They will be fixed in another PR

Copy link
Contributor

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganfra ganfra merged commit 6938b1d into develop Aug 8, 2018
@ganfra ganfra deleted the feature/room_tag_comparator branch August 8, 2018 13:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants