Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for animated discord guild icons #495

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

Sorunome
Copy link
Collaborator

Implements #486

@Sorunome Sorunome requested a review from Half-Shot June 13, 2019 08:47
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@@ -207,7 +207,9 @@ export class ChannelSyncroniser {
const icon = channel.guild.icon;
let iconUrl: string | null = null;
if (icon) {
iconUrl = `https://cdn.discordapp.com/icons/${channel.guild.id}/${icon}.png`;
// if discord prefixes their icon hashes with "a_" it means that they are animated
const animatedIcon: boolean = icon.startsWith("a_");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can leave the type as implied here.

@Sorunome Sorunome merged commit 6ed4eb1 into develop Jun 13, 2019
@Sorunome Sorunome mentioned this pull request Jun 13, 2019
@Sorunome Sorunome deleted the soru/animated-guild-icons branch July 1, 2019 20:36
@jaller94 jaller94 added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements. and removed feature labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants