-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define power levels to disable calls/reactions/redaction/stickers in PMs initiated from IRC #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.33.0
0.35.1
Signed-off-by: Valentin Lorentz <progval plus matrixsignoff at progval dot net> |
No one but the sender can see them because we cannot bridge them. Blocking them with PLs allows the clients to hide these features from their UI, so users do not mistakenly believe they will be received.
ping? |
progval
changed the title
Define power levels to disable calls/reactions/redaction/stickers in PM
Define power levels to disable calls/reactions/redaction/stickers in PMs initiated from IRC
Mar 4, 2023
Half-Shot
requested changes
May 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but needs to be targeting develop
.
Half-Shot
approved these changes
May 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay
Half-Shot
added a commit
that referenced
this pull request
Jun 9, 2023
…PMs initiated from IRC (#1663) * Patch a number of packages * changelog * Ensure tests work for upgrades * Fix tests properly * 0.26.1 * Update node-irc to 1.2.1 and bump version to 0.34.0 * Define power levels to disable calls/reactions/redaction/stickers in PM No one but the sender can see them because we cannot bridge them. Blocking them with PLs allows the clients to hide these features from their UI, so users do not mistakenly believe they will be received. * Block redactions, more call event types, and widgets --------- Co-authored-by: Will Hunt <willh@matrix.org> Co-authored-by: Tadeusz Sośnierz <tadeusz@sosnierz.com> Co-authored-by: Half-Shot <will@half-shot.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No one but the sender can see them because we cannot bridge them. Blocking them with PLs allows the clients to hide these features from their UI, so users do not mistakenly believe they will be received.