Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define power levels to disable calls/reactions/redaction/stickers in PMs initiated from IRC #1663

Merged
merged 19 commits into from
May 2, 2023

Conversation

progval
Copy link
Contributor

@progval progval commented Feb 17, 2023

No one but the sender can see them because we cannot bridge them. Blocking them with PLs allows the clients to hide these features from their UI, so users do not mistakenly believe they will be received.

@progval progval requested a review from a team as a code owner February 17, 2023 20:47
@progval
Copy link
Contributor Author

progval commented Feb 17, 2023

Signed-off-by: Valentin Lorentz <progval plus matrixsignoff at progval dot net>

No one but the sender can see them because we cannot bridge them.
Blocking them with PLs allows the clients to hide these features
from their UI, so users do not mistakenly believe they will be received.
@progval
Copy link
Contributor Author

progval commented Mar 4, 2023

ping?

@progval progval changed the title Define power levels to disable calls/reactions/redaction/stickers in PM Define power levels to disable calls/reactions/redaction/stickers in PMs initiated from IRC Mar 4, 2023
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but needs to be targeting develop.

@Half-Shot Half-Shot changed the base branch from master to develop May 2, 2023 14:48
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay

@Half-Shot Half-Shot merged commit 6ce85b3 into matrix-org:develop May 2, 2023
Half-Shot added a commit that referenced this pull request Jun 9, 2023
…PMs initiated from IRC (#1663)

* Patch a number of packages

* changelog

* Ensure tests work for upgrades

* Fix tests properly

* 0.26.1

* Update node-irc to 1.2.1 and bump version to 0.34.0

* Define power levels to disable calls/reactions/redaction/stickers in PM

No one but the sender can see them because we cannot bridge them.
Blocking them with PLs allows the clients to hide these features
from their UI, so users do not mistakenly believe they will be received.

* Block redactions, more call event types, and widgets

---------

Co-authored-by: Will Hunt <willh@matrix.org>
Co-authored-by: Tadeusz Sośnierz <tadeusz@sosnierz.com>
Co-authored-by: Half-Shot <will@half-shot.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants