Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: don't push on a Pull Request #1767

Merged
merged 3 commits into from
Aug 8, 2023
Merged

docker: don't push on a Pull Request #1767

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
702b95d
docker: don't push on a Pull Request
gdamjan Aug 7, 2023
3944747
Create 1767.bugfix
Half-Shot Aug 7, 2023
a7be8d9
check if env.PUSH is the "true" string
gdamjan Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/docker-hub-latest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ env:
DOCKER_NAMESPACE: matrixdotorg
PLATFORMS: linux/amd64
# Only push if this is develop, otherwise we just want to build
PUSH: ${{ github.ref == 'refs/heads/develop' }}
# On a PR github.ref is the target branch, so don't push for that either
PUSH: ${{ github.ref == 'refs/heads/develop' && github.event_name != 'pull_request' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, the jobs might need a env.PUSH == 'true' perhaps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, indeed, since PUSH is an env var.


jobs:
docker-latest:
Expand All @@ -34,4 +35,4 @@ jobs:
platforms: ${{ env.PLATFORMS }}
push: ${{ env.PUSH }}
tags: |
${{ env.DOCKER_NAMESPACE }}/matrix-appservice-irc:latest
${{ env.DOCKER_NAMESPACE }}/matrix-appservice-irc:latest
1 change: 1 addition & 0 deletions changelog.d/1767.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix GitHub CI docker builds failing for community PRs.
Loading