Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

Commit

Permalink
Set the session pagination to use query parameters
Browse files Browse the repository at this point in the history
Also reverses the order of the sessions to show the most recent ones first.

Fixes #1497
  • Loading branch information
sandhose committed Feb 19, 2024
1 parent 1c000a1 commit b8ab974
Show file tree
Hide file tree
Showing 21 changed files with 1,012 additions and 1,549 deletions.
5 changes: 2 additions & 3 deletions frontend/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@
"title": "Invalid email"
}
},
"app_sessions_list": {
"heading": "Apps"
},
"browser_session_details": {
"current_badge": "Current",
"session_details_title": "Session"
Expand Down Expand Up @@ -165,6 +162,8 @@
"display_name_field_label": "Display Name"
},
"user_sessions_overview": {
"active_sessions:one": "{{count}} active session",
"active_sessions:other": "{{count}} active sessions",
"heading": "Where you're signed in"
},
"verify_email": {
Expand Down
126 changes: 0 additions & 126 deletions frontend/src/components/BrowserSessionList.tsx

This file was deleted.

1 change: 1 addition & 0 deletions frontend/src/components/ButtonLink.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export const ButtonLink: LinkComponent<Props> = forwardRef<
kind={kind}
size={size}
destructive={destructive}
disabled={props.disabled}

Check warning on line 38 in frontend/src/components/ButtonLink.tsx

View check run for this annotation

Codecov / codecov/patch

frontend/src/components/ButtonLink.tsx#L38

Added line #L38 was not covered by tests
Icon={Icon}
ref={ref}
{...linkProps}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ const BrowserSessionDetail: React.FC<Props> = ({ session }) => {
{t("frontend.browser_session_details.current_badge")}
</Badge>
)}
<SessionHeader to="/sessions">{sessionName}</SessionHeader>
<SessionHeader to="/sessions/browsers">{sessionName}</SessionHeader>

Check warning on line 135 in frontend/src/components/SessionDetail/BrowserSessionDetail.tsx

View check run for this annotation

Codecov / codecov/patch

frontend/src/components/SessionDetail/BrowserSessionDetail.tsx#L135

Added line #L135 was not covered by tests
<SessionDetails
title={t("frontend.browser_session_details.session_details_title")}
details={sessionDetails}
Expand Down
73 changes: 0 additions & 73 deletions frontend/src/components/SessionDetail/SessionDetail.tsx

This file was deleted.

15 changes: 0 additions & 15 deletions frontend/src/components/SessionDetail/index.ts

This file was deleted.

26 changes: 0 additions & 26 deletions frontend/src/components/SessionList/SessionListHeader.module.css

This file was deleted.

78 changes: 0 additions & 78 deletions frontend/src/components/SessionList/SessionListHeader.stories.tsx

This file was deleted.

36 changes: 0 additions & 36 deletions frontend/src/components/SessionList/SessionListHeader.test.tsx

This file was deleted.

Loading

0 comments on commit b8ab974

Please sign in to comment.