Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

Return after handling an error when getting a file #60

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

babolivier
Copy link
Contributor

@babolivier babolivier commented Dec 8, 2021

Fixes #55

It looks like the code assumes reject returns after handling an error, which doesn't seem to be the case in javascript.
Also improve the error handling a bit so the client doesn't get Unhandled server error.

Introduced in #47

@babolivier babolivier requested a review from a team as a code owner December 8, 2021 18:20
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I wonder if this is something a linter would catch. Setting up eslint would be a good investment if we're going to be maintaining this project long term.

@babolivier
Copy link
Contributor Author

Setting up eslint would be a good investment if we're going to be maintaining this project long term.

That's a good point.
I don't hope we're going to maintain this long term, since I'd like there to be a Python replacement sooner than later, but even then setting up a linter doesn't sound like something that would be super non-trivial, and it sounds quite valuable, I'll look into it.

@babolivier babolivier merged commit 84a26ee into main Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having no DNS leads to a crash with no useful infos
2 participants