Use MXIdentityService to perform identity server requests

CHANGES.rst

@@ -5,6 +5,7 @@ Improvements:
  * Upgrade MatrixSDK version ([v0.13.1](https://github.com/matrix-org/matrix-ios-sdk/releases/tag/v0.13.1)).
  * Support soft logout (vector-im/riot-ios/issues/2540).
  * MXKRoomBubbleCellData: Add method to get bubble component index from event id.
+ * Use MXIdentityService to perform identity server requests (vector-im/riot-ios#2647).
 
  Bug fix:
  * APNS Push: fix logic when enabling APNS push. Avoid calling nil callback method.

MatrixKit/Controllers/MXKAuthenticationViewController.m

@@ -75,6 +75,11 @@ The timer used to postpone the registration when the authentication is pending (
     NSTimer* registrationTimer;
 }
 
+/**
+ The identity service used to make identity server API requests.
+ */
+@property (nonatomic) MXIdentityService *identityService;
+
 @end
 
 @implementation MXKAuthenticationViewController
@@ -506,11 +511,17 @@ - (void)setIdentityServerTextFieldText:(NSString *)identityServerUrl
 {    
     _identityServerTextField.text = identityServerUrl;
 
-    // Update REST client
-    if (![mxRestClient.identityServer isEqualToString:identityServerUrl])
+    [self updateIdentityServerURL:identityServerUrl];
+}
+
+- (void)updateIdentityServerURL:(NSString*)url
+{
+    if (![self.identityService.identityServer isEqualToString:url])
     {
-        [mxRestClient setIdentityServer:identityServerUrl];
+        self.identityService = [[MXIdentityService alloc] initWithIdentityServer:url];
     }
+
+    [mxRestClient setIdentityServer:url];
 }
 
 - (void)setUserInteractionEnabled:(BOOL)userInteractionEnabled
@@ -1469,7 +1480,7 @@ - (void)updateRESTClient
 
             if (_identityServerTextField.text.length)
             {
-                [mxRestClient setIdentityServer:_identityServerTextField.text];
+                [self updateIdentityServerURL:self.identityServerTextField.text];
             }
         }
     }
@@ -1877,6 +1888,11 @@ - (MXRestClient *)authInputsViewThirdPartyIdValidationRestClient:(MXKAuthInputsV
     return mxRestClient;
 }
 
+- (MXIdentityService *)authInputsViewThirdPartyIdValidationIdentityService:(MXIdentityService *)authInputsView
+{
+    return self.identityService;
+}
+
 #pragma mark - Authentication Fallback
 
 - (void)showAuthenticationFallBackView

MatrixKit/Models/Account/MXKAccount.m

@@ -269,11 +269,15 @@ - (void)setIdentityServerURL:(NSString *)identityServerURL
         _identityServerURL = identityServerURL;
         // Update the current restClient
         [mxRestClient setIdentityServer:identityServerURL];
+
+        // Update identity service
+        mxSession.identityService = [[MXIdentityService alloc] initWithIdentityServer:identityServerURL];
     }
     else
     {
-        _identityServerURL = nil;        
+        _identityServerURL = nil;
         [mxRestClient setIdentityServer:nil];
+        mxSession.identityService = nil;
     }
 
     // Archive updated field

MatrixKit/Models/Contact/MXKContactManager.m

@@ -72,9 +72,10 @@ Listeners registered on matrix presence and membership events (one by matrix ses
 }
 
 /**
- The current REST client defined with the identity server.
+ The current identity service defined with the identity server.
  */
-@property (nonatomic) MXRestClient *identityRESTClient;
+@property (nonatomic) MXIdentityService *identityService;
+
 @end
 
 @implementation MXKContactManager
@@ -135,7 +136,6 @@ -(void)dealloc
     mxSessionArray = nil;
     mxEventListeners = nil;
     _identityServer = nil;
-    _identityRESTClient = nil;
 
     [[MXKAppSettings standardAppSettings] removeObserver:self forKeyPath:@"syncLocalContacts"];
     [[MXKAppSettings standardAppSettings] removeObserver:self forKeyPath:@"phonebookCountryCode"];
@@ -274,8 +274,8 @@ - (void)removeMatrixSession:(MXSession*)mxSession
         [mxEventListeners removeObjectAtIndex:index];
         [mxSessionArray removeObjectAtIndex:index];
 
-        // Reset the current rest client (It will be rebuild if need)
-        _identityRESTClient = nil;
+        // Reset the current identity service (It will be rebuild if need)
+        self.identityService = nil;
 
         if (!mxSessionArray.count) {
             if (mxSessionStateObserver) {
@@ -489,49 +489,43 @@ - (void)setIdentityServer:(NSString *)identityServer
 
     if (identityServer)
     {
-        MXCredentials *credentials = [MXCredentials new];
-        credentials.identityServer = identityServer;
-
-        _identityRESTClient = [[MXRestClient alloc] initWithCredentials:credentials andOnUnrecognizedCertificateBlock:nil];
+        self.identityService = [[MXIdentityService alloc] initWithIdentityServer:identityServer];
 
         // Lookup the matrix users in all the local contacts.
         [self updateMatrixIDsForAllLocalContacts];
     }
     else
     {
-        _identityRESTClient = nil;
+        self.identityService = nil;
     }
 }
 
-- (MXRestClient*)identityRESTClient
+- (MXIdentityService*)identityService
 {
-    if (!_identityRESTClient)
+    if (!_identityService)
     {
+        NSString *identityServer;
+
         if (self.identityServer)
         {
-            MXCredentials *credentials = [MXCredentials new];
-            credentials.identityServer = self.identityServer;
-
-            _identityRESTClient = [[MXRestClient alloc] initWithCredentials:credentials andOnUnrecognizedCertificateBlock:nil];
+            identityServer = self.identityServer;
         }
         else if (mxSessionArray.count)
         {
             MXSession *mxSession = [mxSessionArray firstObject];
-
-            MXCredentials *credentials = [MXCredentials new];
-            credentials.identityServer = mxSession.matrixRestClient.identityServer;
-
-            _identityRESTClient = [[MXRestClient alloc] initWithCredentials:credentials andOnUnrecognizedCertificateBlock:nil];
+            identityServer = mxSession.identityService.identityServer;
         }
+
+        _identityService = [[MXIdentityService alloc] initWithIdentityServer:self.identityServer];
     }
 
-    return _identityRESTClient;
+    return _identityService;
 }
 
 - (BOOL)isUsersDiscoveringEnabled
 {
     // Check whether the 3pid lookup is available
-    return (self.discoverUsersBoundTo3PIDsBlock || self.identityRESTClient);
+    return (self.discoverUsersBoundTo3PIDsBlock || self.identityService);
 }
 
 #pragma mark -
@@ -815,9 +809,9 @@ - (void)updateMatrixIDsForLocalContact:(MXKContact *)contact
             else
             {
                 // Consider the potential identity server url by default
-                [self.identityRESTClient lookup3pids:lookup3pidsArray
-                                             success:success
-                                             failure:failure];
+                [self.identityService lookup3pids:lookup3pidsArray
+                                          success:success
+                                          failure:failure];
             }
         }
     }
@@ -928,9 +922,9 @@ - (void)updateMatrixIDsForAllLocalContacts
             }
             else
             {
-                [self.identityRESTClient lookup3pids:lookup3pidsArray
-                                             success:success
-                                             failure:failure];
+                [self.identityService lookup3pids:lookup3pidsArray
+                                          success:success
+                                          failure:failure];
             }
         }
         else
@@ -965,7 +959,7 @@ - (void)reset
     mxSessionArray = nil;
     mxEventListeners = nil;
     _identityServer = nil;
-    _identityRESTClient = nil;
+    self.identityService = nil;
 
     // warn of the contacts list update
     [[NSNotificationCenter defaultCenter] postNotificationName:kMXKContactManagerDidUpdateMatrixContactsNotification object:nil userInfo:nil];

MatrixKit/Models/MXK3PID.m

@@ -27,6 +27,8 @@ @interface MXK3PID ()
 @property (nonatomic) NSString *clientSecret;
 @property (nonatomic) NSUInteger sendAttempt;
 @property (nonatomic) NSString *sid;
+@property (nonatomic) MXIdentityService *identityService;
+
 @end
 
 @implementation MXK3PID
@@ -50,6 +52,7 @@ - (void)cancelCurrentRequest
     [currentRequest cancel];
     currentRequest = nil;
     mxRestClient = nil;
+    self.identityService = nil;
 
     self.sendAttempt = 1;
     self.sid = nil;
@@ -77,6 +80,13 @@ - (void)requestValidationTokenWithMatrixRestClient:(MXRestClient*)restClient
             _validationState = MXK3PIDAuthStateTokenRequested;
             mxRestClient = restClient;
 
+            NSString *identityServer = restClient.credentials.identityServer;
+            if (identityServer)
+            {
+                // Use same identity server as REST client for validation token submission
+                self.identityService = [[MXIdentityService alloc] initWithIdentityServer:identityServer];
+            }
+
             currentRequest = [mxRestClient requestTokenForEmail:self.address isDuringRegistration:isDuringRegistration clientSecret:self.clientSecret sendAttempt:self.sendAttempt nextLink:nextLink success:^(NSString *sid) {
 
                 self->_validationState = MXK3PIDAuthStateTokenReceived;
@@ -154,34 +164,51 @@ - (void)submitValidationToken:(NSString *)token
     // Sanity Check
     if (_validationState == MXK3PIDAuthStateTokenReceived)
     {
-        _validationState = MXK3PIDAuthStateTokenSubmitted;
-
-        currentRequest = [mxRestClient submit3PIDValidationToken:token medium:self.medium clientSecret:self.clientSecret sid:self.sid success:^{
-
-            self->_validationState = MXK3PIDAuthStateAuthenticated;
-            self->currentRequest = nil;
-
-            if (success)
-            {
-                success();
-            }
-
-        } failure:^(NSError *error) {
+        if (self.identityService)
+        {
+            _validationState = MXK3PIDAuthStateTokenSubmitted;
 
-            // Return in previous state
-            self->_validationState = MXK3PIDAuthStateTokenReceived;
-            self->currentRequest = nil;
+            currentRequest = [self.identityService submit3PIDValidationToken:token medium:self.medium clientSecret:self.clientSecret sid:self.sid success:^{
+
+                self->_validationState = MXK3PIDAuthStateAuthenticated;
+                self->currentRequest = nil;
+
+                if (success)
+                {
+                    success();
+                }
+
+            } failure:^(NSError *error) {
+
+                // Return in previous state
+                self->_validationState = MXK3PIDAuthStateTokenReceived;
+                self->currentRequest = nil;
+
+                if (failure)
+                {
+                    failure (error);
+                }
+
+            }];
+        }
+        else
+        {
+            NSLog(@"[MXK3PID] Failed to submit validation token for 3PID: %@ (%@), identity service is not set", self.address, self.medium);
 
             if (failure)
             {
-                failure (error);
+                failure(nil);
             }
-
-        }];
+        }
     }
     else
     {
         NSLog(@"[MXK3PID] Failed to submit validation token for 3PID: %@ (%@), state: %lu", self.address, self.medium, (unsigned long)_validationState);
+
+        if (failure)
+        {
+            failure(nil);
+        }
     }
 }
 

MatrixKit/Views/Authentication/MXKAuthInputsView.h

@@ -69,6 +69,11 @@ typedef enum {
  */
 - (MXRestClient *)authInputsViewThirdPartyIdValidationRestClient:(MXKAuthInputsView *)authInputsView;
 
+/**
+ The identity service used to validate third-party identifiers.
+ */
+- (MXIdentityService *)authInputsViewThirdPartyIdValidationIdentityService:(MXKAuthInputsView *)authInputsView;
+
 /**
  Tell the delegate to present a view controller modally.