This repository has been archived by the owner on Dec 12, 2022. It is now read-only.
PushKit: Delete any pending PushKit pusher #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
element-hq/element-ios/issues/3577. This reverts #646. Game rules have changed. We cannot use/abuse PushKit as before iOS13 SDK. We have to use APNS. So, we can safely clean PushKit pusher.
SBiOSoftWhare
approved these changes
Aug 31, 2020
SBiOSoftWhare
approved these changes
Sep 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
element-hq/element-ios/issues/3577.
This reverts #646. Game rules have changed. We cannot use/abuse PushKit as before iOS13 SDK. We have to use APNS. So, we can safely clean PushKit pusher.
This mitigates the race condition where element-hq/element-ios#3578 removes the pusher while
MXAccountcan refresh it in parallel on aMXSessionstate change. At the end of the refresh, the pusher is restored :/This works because element-hq/element-ios#3578 does not clear the
MXKAccount.hasPusherForPushKitNotifications, which is still true after element-hq/element-ios#3578