This repository has been archived by the owner on Dec 12, 2022. It is now read-only.
Fix collapsing of separately processed events #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in element-hq/element-ios#4102, membership changes are sometimes wrongly collapsed. This happens when events of the same collapsible series are processed in different batches. For forward directed events, only the start of a collapsible series is tracked in `collapsingCellDataSeriess`. As a result, when the event that corresponds to the beginning of the series was processed in a preceding event batch, the series will be missing in `collapsingCellDataSeriess` and its summary string won't get updated. This commit fixes the situation by adding the start of the series to `collapsingCellDataSeriess` when it is missing and the series is appended to. Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in element-hq/element-ios#4102, membership changes are sometimes wrongly collapsed. This happens when events of the same collapsible series are processed in different batches. For forward directed events, only the start of a collapsible series is tracked in
collapsingCellDataSeriess. As a result, when the event that corresponds to the beginning of the series was processed in a preceding event batch, the series will be missing incollapsingCellDataSeriessand its summary string won't get updated.This commit fixes the situation by adding the start of the series to
collapsingCellDataSeriesswhen it is missing and the series is appended to.Signed-off-by: Johannes Marbach n0-0ne+github@mailbox.org
Pull Request Checklist