Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MXJSONModel: disable init and new methods #582

Open
manuroe opened this issue Oct 18, 2018 · 0 comments
Open

MXJSONModel: disable init and new methods #582

manuroe opened this issue Oct 18, 2018 · 0 comments
Labels
enhancement help wanted

Comments

@manuroe
Copy link
Contributor

manuroe commented Oct 18, 2018

We have factories to parse JSON dictionaries into that objects.
In order to ensure nullability for #581, we should disable init and new methods in the MXJSONModel class and force usage of factory methods.

- (instancetype)init NS_UNAVAILABLE;
+ (instancetype)new NS_UNAVAILABLE;
manuroe added a commit that referenced this issue Oct 24, 2018
@manuroe
Keys backup: MXKeyBackupVersion: Guarantee parameters non-nullabililty
0cbbeef 
This is what could be done for #582.
manuroe added a commit that referenced this issue Nov 5, 2018
@manuroe
Keys backup: MXKeyBackupVersion: Guarantee parameters non-nullabililty
89c9a0c 
This is what could be done for #582.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@manuroe