Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poll support #1295

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Poll support #1295

merged 2 commits into from
Nov 16, 2021

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Nov 15, 2021 •
edited
Loading

  • added MXRoom poll event sending methods
  • added poll aggregator with integration tests
  • added poll model builder with unit tests
  • changed the MacOS testing target to not use optimizations
  • changed MXAggregations limit parameters to be NSIntegers instead of NSUIntegers as the limit can be -1

SBiOSoftWhare
SBiOSoftWhare reviewed Nov 16, 2021
View reviewed changes
@stefanceriu
element-hq/element-ios/issues/5114 - Various code style tweaks follow…
72ca638 
…ing code review. Introduced immutable poll interface exposed by the aggregator and builder.
@stefanceriu stefanceriu merged commit 07db42d into develop Nov 16, 2021
@stefanceriu stefanceriu deleted the stefan/polls branch November 16, 2021 11:31
@turt2live turt2live mentioned this pull request Jan 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SBiOSoftWhare SBiOSoftWhare SBiOSoftWhare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @SBiOSoftWhare