Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DTMF #1335

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Fix DTMF #1335

merged 2 commits into from
Jan 12, 2022

Conversation

langleyd
Copy link
Contributor

@langleyd langleyd commented Jan 12, 2022 •
edited
Loading

Fixes element-hq/element-ios#5375
with element-hq/element-ios#5376

I decided to match the implementation of android:

  • We don't make use of the additional parameters and it complicates the logic a bit, so simplified the signature.
  • android loops though the senders to get the dtmf sender which seems slightly more robust
  • Android just hardcodes the duration and gap, copied the values.
  • The input is NSTimeInterval which is seconds rather than ms. This differs from the android webrtc api which passes as ms.

@langleyd langleyd self-assigned this Jan 12, 2022
@langleyd langleyd mentioned this pull request Jan 12, 2022
Merged
@ismailgulek
Copy link
Contributor

We could add a changelog.

@langleyd langleyd merged commit 8522b47 into develop Jan 12, 2022
@langleyd langleyd deleted the langleyd/5375_fix_dtmf branch January 12, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismailgulek ismailgulek ismailgulek approved these changes

Assignees

@langleyd langleyd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DTMF not working
2 participants
@langleyd @ismailgulek